Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOGL-8190 Temporarily revert to statistics collection per asset and #1196

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

MarkRiddoch
Copy link
Contributor

service as the default for south services

This will be reverted after the next release and a GUI change done for the display of south services

service as the default for south services

Signed-off-by: Mark Riddoch <[email protected]>
@@ -75,12 +75,15 @@ The south services within Fledge each have a set of advanced configuration optio
| |stats_options| |
+-----------------+

The *per asset & per service* setting will collect one statistic per asset ingested and an overall statistic for the entire service. The *per service* option just collects the overall service ingest statistics and the *per asset* option just collects the statistics for each asset and not for the entire service. The default is to collect statistics on a per service basis, use of the per asset or the per asset and service options should be limited to south service that collect a relatively small number of distinct assets. Collecting large number of statistics, for 1000 or more distinct assets will have a significant performance overhead and may overwhelm less well provisioned Fledge instances.
The *per asset & per service* setting will collect one statistic per asset ingested and an overall statistic for the entire service. The *per service* option just collects the overall service ingest statistics and the *per asset* option just collects the statistics for each asset and not for the entire service. The default is to collect statistics on a per asset & service basis, this is not the best setting if large numbers of distinct assets are ingested by a single south service. Use of the per asset or the per asset and service options should be limited to south service that collect a relatively small number of distinct assets. Collecting large number of statistics, for 1000 or more distinct assets will have a significant performance overhead and may overwhelm less well provisioned Fledge instances. When a large number of assets are ingested by a single south service this value should be set to *per service*.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

option is: per asset & service

@ashish-jabble
Copy link
Member

@Mohit04tomar fyi, We need to do updates on #1193

Smoke tests should be okay with this PR and should be removed from your PR. And for the rest of the tests, we need to add default=True in stats collection fixture when True nothing to be changed in Config item else update with payload you need to test with.

@MarkRiddoch
Copy link
Contributor Author

@Mohit04tomar fyi, We need to do updates on #1193

Smoke tests should be okay with this PR and should be removed from your PR. And for the rest of the tests, we need to add default=True in stats collection fixture when True nothing to be changed in Config item else update with payload you need to test with.

I would suggest we write all tests so that if they need a particular setting, even if it is the default, then they explicitly set that value. This would make them more robust to defaults being changed.

@MarkRiddoch MarkRiddoch merged commit db19358 into develop Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants