FOGL-8264: fix Send Full Structure so only PI Points are created when false #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ray Verhoeff <[email protected]>
Signed-off-by: Ray Verhoeff <[email protected]>
Signed-off-by: Ray Verhoeff <[email protected]>
MarkRiddoch
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Send full structure configuration boolean was false, OMF North would create an AF structure anyways. All AF Elements were at the root of the AF database, and every AF Element had a single AF Attribute mapped to a PI Point. Creation of this AF structure would take a long time for large databases which would lead to PI Web API POST timeouts. This has been fixed. If the configuration boolean is false, create only PI Points. In the configuration page, Send full structure has been renamed to Create AF Structure.
The OMF North documentation page has not been updated. The page will need new screenshots.
As part of this work, logging in the omf.log file has been improved by adding elapsed time and current time for all REST operations, including when an exception is thrown by the HTTP client toolkits.