Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLI-531] User theme preference should be persisted. #1933

Closed
charlesoconor opened this issue Jul 31, 2023 · 6 comments
Closed

[FLI-531] User theme preference should be persisted. #1933

charlesoconor opened this issue Jul 31, 2023 · 6 comments
Assignees
Milestone

Comments

@charlesoconor
Copy link
Contributor

charlesoconor commented Jul 31, 2023

Describe the Bug

When a session has expired, the UI will be reset to the theme, "Light". Would persist until the user makes a change.

Not a huge deal but I like using the dark mode.

Version Info

 _____ _ _       _
|  ___| (_)_ __ | |_
| |_  | | | '_ \| __|
|  _| | | | |_) | |_
|_|   |_|_| .__/ \__|
          |_|

Version: v1.24.0
Commit: 2df57db6bcec306346e364a793fba422f2f9a93a
Build Date: 2023-07-31T13:54:06Z
Go Version: go1.20.6

To Reproduce

Change UI theme to anything besides light. Wait for the session to be revoked. The theme will be reset to the default.

FLI-531

@markphelps markphelps changed the title User theme preference should be persisted. [FLI-531] User theme preference should be persisted. Jul 31, 2023
@markphelps
Copy link
Collaborator

💯 , i encountered this before and totally forgot to file an issue. Thanks for bringing it to our attention! Will get it fixed!

@markphelps
Copy link
Collaborator

markphelps commented Jul 31, 2023

Was able to reproduce using the Dex OIDC example

  1. cd examples/authentication/dex
  2. $ docker-compose up --build
  3. login with [email protected]/password
  4. change them to dark
  5. logout
  6. login again
  7. see theme is back to light (local storage is cleared)

CleanShot 2023-07-31 at 16 55 05

CleanShot 2023-07-31 at 16 55 36

@gaby
Copy link

gaby commented Aug 1, 2023

Would it make sense to add an ENV variable to force a specific theme for everyone?

@markphelps markphelps self-assigned this Aug 1, 2023
@markphelps
Copy link
Collaborator

Would it make sense to add an ENV variable to force a specific theme for everyone?

Maybe a default starting theme that could be overridden in each browser?

@markphelps
Copy link
Collaborator

Hey @charlesoconor this fix will be going out today in v1.24.2 release happening now!

lmk if it fixes your issue

@charlesoconor
Copy link
Contributor Author

Just upgraded my instance. Looks like its working. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants