-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variants keys should be unique per flag, not globally #87
Labels
Comments
Great point and thank you for the issue! Will work on this ASAP. |
@twgraham this has been merged, but am planning to make some changes on how migrations are run to make them safer before cutting a new release. should have that done and a new release cut by this weekend |
Woohoo! Thanks @markphelps 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When trying to create a variant for a flag where the key is default, I'm getting an error suggesting that the key needs to be unique, despite the no existing variants for the flag. I do have a variant with the key default on another flag though.
I would expect that the keys for variants should be unique per flag rather than globally, since there is no way that these variants can be used across flags.
The text was updated successfully, but these errors were encountered: