Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arm64 builds #1005

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Support arm64 builds #1005

merged 2 commits into from
Sep 6, 2022

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Sep 5, 2022

Update the goreleaesr config with:

  • arm64 binary builds
  • mutli-arch docker image builds

Also, add the newly required dependencies for multi-arch builds to the
Github Actions workflows.

@jalaziz
Copy link
Contributor Author

jalaziz commented Sep 5, 2022

I've tested the workflow changes on my fork. You can download and test the multi-arch image here: https:/jalaziz/flipt/pkgs/container/flipt

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you @jalaziz! just two minor typos

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/snapshot.yml Outdated Show resolved Hide resolved
@markphelps
Copy link
Collaborator

@all-contributors please add @jalaziz for platform

@allcontributors
Copy link
Contributor

@markphelps

I've put up a pull request to add @jalaziz! 🎉

Update the goreleaesr config with:
* arm64 binary builds
* mutli-arch docker image builds

Also, add the newly required dependencies for multi-arch builds to the
Github Actions workflows.
@markphelps markphelps enabled auto-merge (squash) September 6, 2022 16:53
@markphelps markphelps merged commit 1a9e9ae into flipt-io:main Sep 6, 2022
@jalaziz jalaziz deleted the arm64 branch September 6, 2022 19:33
markphelps added a commit that referenced this pull request Sep 6, 2022
…nto buf-google-apis

* 'buf-google-apis' of https:/flipt-io/flipt:
  docs: add jalaziz as a contributor for platform (#1010)
  Support arm64 builds (#1005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants