feat(rpc/auth): add OIDC auth method service gRPC definition #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
+ Coverage 79.65% 79.87% +0.21%
==========================================
Files 38 38
Lines 2758 2758
==========================================
+ Hits 2197 2203 +6
+ Misses 455 451 -4
+ Partials 106 104 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
markphelps
approved these changes
Dec 1, 2022
markphelps
reviewed
Dec 12, 2022
| @@ -32,6 +35,106 @@ | |||
| "application/json" | |||
| ], | |||
| "paths": { | |||
| "/auth/v1/method/oidc/{provider}/authorize": { | |||
| "get": { | |||
There was a problem hiding this comment.
note: we should remove this generated swagger schema as well as the others in favor of the newer handwritten openapi3 schema used to power the docs in https:/flipt-io/flipt-openapi
FLI-107
markphelps
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #779
Fixes: FLI-46
This adds the gRPC definitions for the OIDC Authentication Method service.
Implementations will come in a later PR.
The two primary operations for this service are:
AuthorizeURLThis operation will return a valid authorize URL for the requested provider.
CallbackThis operation will handle the callback from the authentication service redirect.
The result of this operation (if successful) will be a valid client token and authentication instance.