Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm duplicate grpc shutdown log #1282

Merged
merged 1 commit into from
Jan 23, 2023
Merged

chore: rm duplicate grpc shutdown log #1282

merged 1 commit into from
Jan 23, 2023

Conversation

markphelps
Copy link
Collaborator

Noticed this when shutting down the latest rc release:

^C2023-01-20T20:45:46Z	INFO	shutting down...
2023-01-20T20:45:46Z	INFO	shutting down HTTP server...	{"server": "http"}
2023-01-20T20:45:46Z	INFO	shutting down GRPC server...	{"server": "grpc"}
2023-01-20T20:45:46Z	INFO	shutting down grpc server...	{"server": "grpc"}

This PR removes the last line (duplicate message)

@markphelps markphelps requested a review from a team as a code owner January 20, 2023 20:49
@markphelps markphelps enabled auto-merge (squash) January 20, 2023 20:51
GeorgeMac
GeorgeMac approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@markphelps markphelps merged commit 1005306 into main Jan 23, 2023
@markphelps markphelps deleted the dupe-grpc-shutdown-log branch January 23, 2023 10:32
markphelps added a commit that referenced this pull request Jan 23, 2023
@markphelps
Merge branch 'main' into release/1.18
ead8e6c 
* main:
  chore: rm duplicate grpc shutdown log (#1282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @GeorgeMac