fix: import for cockroach db #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
added a commit
that referenced
this pull request
Mar 15, 2023
* main: (36 commits) feat(sdk/go): thread client token on RPC calls when provided (#1389) docs: update .all-contributorsrc [skip ci] docs: update README.md [skip ci] chore(deps): bump google.golang.org/protobuf in /_tools (#1401) chore(deps): bump google.golang.org/protobuf from 1.29.0 to 1.29.1 (#1400) fix: return better error messages for grpc-gateway errors (#1397) fix: import for cockroach db (#1399) chore(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /_tools (#1394) chore: update readme w better usecase verbiage (#1395) fix(sdk/go): documentation and example corrections chore(deps): bump google.golang.org/protobuf from 1.28.1 to 1.29.0 (#1393) chore(deps): bump google.golang.org/protobuf in /_tools (#1391) chore(sdk/go): fix README markdown style fix(sdk/go): drop support for single field message mangling chore(sdk/go): add README chore(gowork): go edit -fmt feat(sdk/go): add doc.go feat(sdk/go): add static client token provider refactor(sdk/go): move grpc transport into its own subpackage chore(proto): regenerate RPC using protoc-gen-go-grpc v1.3.0 ...
markphelps
added a commit
that referenced
this pull request
Mar 15, 2023
* namespaces: (31 commits) Release/1.19 (#1403) feat(sdk/go): thread client token on RPC calls when provided (#1389) docs: update .all-contributorsrc [skip ci] docs: update README.md [skip ci] chore(deps): bump google.golang.org/protobuf in /_tools (#1401) chore(deps): bump google.golang.org/protobuf from 1.29.0 to 1.29.1 (#1400) fix: return better error messages for grpc-gateway errors (#1397) fix: import for cockroach db (#1399) chore(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /_tools (#1394) chore: update readme w better usecase verbiage (#1395) fix(sdk/go): documentation and example corrections chore(deps): bump google.golang.org/protobuf from 1.28.1 to 1.29.0 (#1393) chore(deps): bump google.golang.org/protobuf in /_tools (#1391) chore(sdk/go): fix README markdown style fix(sdk/go): drop support for single field message mangling chore(sdk/go): add README chore(gowork): go edit -fmt feat(sdk/go): add doc.go feat(sdk/go): add static client token provider refactor(sdk/go): move grpc transport into its own subpackage ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #1396 I saw that if you tried to run import using cockroachDB you would get a nil pointer error. This is because we never added
cockroachDBto the switch statement for import/export commands.. oops