fix: protojson to use DiscardUnknown option for backwards compatibility #1453
Conversation
…ty with namespace changes
| @@ -289,7 +289,7 @@ func generateHTTPMethod(g *protogen.GeneratedFile, m mappings, method *protogen. | |||
| return | |||
| } | |||
|
|
|||
| g.P("if err := ", protojson("Unmarshal"), "(respData, &output); err != nil { return nil, err }") | |||
| g.P("if err := ", "(protojson.UnmarshalOptions{DiscardUnknown: true}).Unmarshal", "(respData, &output); err != nil { return nil, err }") | |||
There was a problem hiding this comment.
| g.P("if err := ", "(protojson.UnmarshalOptions{DiscardUnknown: true}).Unmarshal", "(respData, &output); err != nil { return nil, err }") | |
| g.P("if err := (", protojson("UnmarshalOptions"), "{DiscardUnknown: true}).Unmarshal", "(respData, &output); err != nil { return nil, err }") |
There was a problem hiding this comment.
This might seem a little weird. However, it will just ensure that protojson is always imported appropriately at the top of the file.
It is being imported elsewhere at the moment, which is why this isn't breaking.
If that were to change though then this could break. So we make sure to use the function here when referencing the type.
There was a problem hiding this comment.
I should have spent more time trying to figure out how to do it with the protojson import 😓 haha thanks. Will make that change right now.
There was a problem hiding this comment.
No worries :D It is a weird thing protogen. Takes some getting used to.
Codecov Report
@@ Coverage Diff @@
## main #1453 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 43 43
Lines 3239 3239
=======================================
Hits 2526 2526
Misses 569 569
Partials 144 144 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The current http sdk client fails with requests against Flipt instances that are namespace aware (according to the proto definitions). We start to see errors like the following:
This is because the http client does not know what to do with unknown fields when it goes to decode the output back out to the user. This change introduces a
DiscardUnknownUnmarshal option, so the client can know what to do with unknown fields relative to the protobuf definition.