chore: move ui back into monorepo #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
+ Coverage 77.60% 77.77% +0.17%
==========================================
Files 44 44
Lines 3402 3402
==========================================
+ Hits 2640 2646 +6
+ Misses 607 603 -4
+ Partials 155 153 -2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
markphelps
commented
Apr 7, 2023
| @@ -6,7 +6,7 @@ package ui | |||
| import "embed" | |||
|
|
|||
| var ( | |||
| //go:embed index.html | |||
| //go:embed dev.html | |||
There was a problem hiding this comment.
TODO: this doesnt work yet. will have to redo the development workflow in another PR
markphelps
commented
Apr 7, 2023
| @@ -0,0 +1,21 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
same as above, this is just copied over for posterity
markphelps
changed the title
|
@all-contributors please add @darinmclain for code |
|
I've put up a pull request to add @darinmclain! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: FLI-219
uidirectoryuifolder instead of cloning from other repoAll of the code in
uiis a direct copy over from the https:/flipt-io/flipt-ui repo as of commitf968a91TODO
(in follow up PRs)
flipt/flipt:nightlyimage