fix 0% distribution issues #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @khepin! Great find and fix! Will cut a new release with this fix now Thanks again |
|
@all-contributors please add @khepin for code |
|
I've put up a pull request to add @khepin! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation skips over distributions that have a 0% rollout and build a buckets array.
The buckets array is accessed by index, but since we skip all 0% distributions, the index of the loop can get out of sync with the last index of the buckets array, creating index out of range errors.
This adds 2 tests specific for the issue and fixes them.
Let me know if this needs updating / re-working.