Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): dont marshal secrets to JSON #2153

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

markphelps
Copy link
Collaborator

do not expose secrets to JSON endpoints

we should come up with a strategy to test for this to prevent regressions and also to guard against any future config options having to do with secrets

@markphelps markphelps requested a review from a team as a code owner September 21, 2023 13:36
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2153 (22712af) into release/1.27 (11f36fa) will decrease coverage by 0.02%.
Report is 4 commits behind head on release/1.27.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.27    #2153      +/-   ##
================================================
- Coverage         70.64%   70.63%   -0.02%     
================================================
  Files                73       73              
  Lines              7066     7066              
================================================
- Hits               4992     4991       -1     
- Misses             1788     1789       +1     
  Partials            286      286              
Files Changed Coverage Δ
internal/config/authentication.go 72.22% <ø> (ø)
internal/config/cache.go 100.00% <ø> (ø)
internal/config/database.go 91.66% <ø> (ø)
internal/config/server.go 100.00% <ø> (ø)
internal/config/storage.go 81.69% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps merged commit b56f594 into release/1.27 Sep 21, 2023
24 of 25 checks passed
@markphelps markphelps deleted the dont-expose-credentials branch September 21, 2023 14:10
markphelps added a commit that referenced this pull request Sep 21, 2023
* release/1.27:
  fix(security): dont marshal secrets to JSON (#2153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants