Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): drop highlight.js #2645

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

erka
Copy link
Collaborator

@erka erka commented Jan 11, 2024

reuse monaco for json formatting.

@erka erka requested a review from a team as a code owner January 11, 2024 16:50
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be73fe7) 73.02% compared to head (10cb8a1) 73.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2645   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          85       85           
  Lines        8325     8325           
=======================================
  Hits         6079     6079           
  Misses       1868     1868           
  Partials      378      378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

reuse monaco for json formatting.
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks/works great! you are on a roll

@markphelps markphelps merged commit ab2229e into flipt-io:main Jan 12, 2024
28 checks passed
@erka erka deleted the ui-drop-highlightjs branch January 12, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants