Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage/fs): threading insecure and ca bundle on fetch #3433

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

GeorgeMac
Copy link
Contributor

Fixes #3432

Threads the insecure skip verify and CA bundle on the Git stores fetch operation.

@GeorgeMac GeorgeMac requested a review from a team as a code owner September 2, 2024 13:23
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.63%. Comparing base (8cc6d58) to head (b7bdcfa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3433      +/-   ##
==========================================
- Coverage   64.65%   64.63%   -0.03%     
==========================================
  Files         174      174              
  Lines       13914    13916       +2     
==========================================
- Hits         8996     8994       -2     
- Misses       4229     4231       +2     
- Partials      689      691       +2     
Flag Coverage Δ
unittests 64.63% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeorgeMac GeorgeMac merged commit cd9feee into main Sep 2, 2024
61 of 62 checks passed
@GeorgeMac GeorgeMac deleted the gm/fix-git-tls-threading branch September 2, 2024 13:51
markphelps added a commit that referenced this pull request Sep 3, 2024
* main:
  fix(storage/fs): threading insecure and ca bundle on fetch (#3433)
  chore: prep changelog (#3420)
  refactor(authz): use lock only during the variables update (#3431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow trust self-signed or trust insecure TLS certificate on git backend
2 participants