Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to quickly duplicate constraints/variants #754

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Mar 18, 2022

Screen Shot 2022-03-17 at 9 27 58 PM

While working on setting up a simliar example as described in #732 in order to start working on a solution, I realized that it was very tedious to create constraints (and variants) that were based on existing ones with only minor differences.

Example:

Constraint 1: { property: 'environment', operator: 'eq', value: 'development' }

Constraint 2: { property: 'environment', operator: 'eq', value: 'staging' }

In this example the constraints only differ by the 'value', but in order to create these contraints in the UI I had to start from scratch each time.

This PR adds

  1. 'duplicate' functionality in the UI for constraints and variants
  2. labels for the icons in the constraints/variants tables
  3. Minor description changes in the Taskfile.

Demo

constraint-dupe

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #754 (e693e65) into master (19f536e) will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   82.09%   82.56%   +0.46%     
==========================================
  Files          19       19              
  Lines        1709     1709              
==========================================
+ Hits         1403     1411       +8     
+ Misses        253      249       -4     
+ Partials       53       49       -4     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f536e...e693e65. Read the comment docs.

@markphelps markphelps merged commit bbf9ffc into master Mar 18, 2022
@markphelps markphelps deleted the duplicate-constraints-variants branch March 18, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants