Fix #1681 #1699
Merged
Fix #1681 #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the error, I replaced
@JsonValuewith@Jsonkey, as illustrated in this commit: link. This adjustment was necessary because json_serializable requires the use of@JsonValuefor enum serialization, not@JsonKey.I believe this issue is significant and may indicate other similar mistakes throughout the codebase. Therefore, I kindly ask you to merge this PR and to address other similar bugs in the codebase.
As @siherrmann mentioned #1681 (comment), this is not merely an enhancement but a critical bug that requires immediate attention.