Move processing of flutter jars to gn. #33124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to remove the artifacts processing logic from recipes. Bug: flutter/flutter#81855
blasten
approved these changes
May 5, 2022
godofredoc
added
the
waiting for tree to go green
zanderso
reviewed
May 5, 2022
| artifact_id = | ||
| string_replace(android_app_abi, "-", "_") + "_" + flutter_runtime_mode | ||
| sources = [ | ||
| "$root_out_dir/${artifact_id}.jar", |
There was a problem hiding this comment.
See https://gn.googlesource.com/gn/+/master/docs/reference.md#func_get_target_outputs.
And to filter down to the outputs that you need, you can use https://gn.googlesource.com/gn/+/master/docs/reference.md#func_filter_include
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to remove the artifacts processing logic from recipes.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.