-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #150515 Provide required headers for build with Clang-16 and GCC … #53479
Fix #150515 Provide required headers for build with Clang-16 and GCC … #53479
Conversation
…14 C++Stdlib backend.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…Clang-16 and GCC … (flutter/engine#53479)
…Clang-16 and GCC … (flutter/engine#53479)
…Clang-16 and GCC … (flutter/engine#53479)
…Clang-16 and GCC … (flutter/engine#53479)
…150968) flutter/engine@ddd4814...94591ff 2024-06-27 [email protected] Roll Skia from cbd6e55139ca to 1700e3962acd (2 revisions) (flutter/engine#53619) 2024-06-27 [email protected] Roll Dart SDK from b5f079c2936e to e7022f6eb6c9 (1 revision) (flutter/engine#53616) 2024-06-27 [email protected] Update DEPS to pull in 8c2d66fa4e6298894425f5bdd0591bc5b1154c53. (flutter/engine#53614) 2024-06-27 [email protected] Roll Skia from c73e514838b4 to cbd6e55139ca (4 revisions) (flutter/engine#53615) 2024-06-27 [email protected] Fix #150515 Provide required headers for build with Clang-16 and GCC â�¦ (flutter/engine#53479) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https:/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#150968) flutter/engine@ddd4814...94591ff 2024-06-27 [email protected] Roll Skia from cbd6e55139ca to 1700e3962acd (2 revisions) (flutter/engine#53619) 2024-06-27 [email protected] Roll Dart SDK from b5f079c2936e to e7022f6eb6c9 (1 revision) (flutter/engine#53616) 2024-06-27 [email protected] Update DEPS to pull in 8c2d66fa4e6298894425f5bdd0591bc5b1154c53. (flutter/engine#53614) 2024-06-27 [email protected] Roll Skia from c73e514838b4 to cbd6e55139ca (4 revisions) (flutter/engine#53615) 2024-06-27 [email protected] Fix flutter#150515 Provide required headers for build with Clang-16 and GCC â�¦ (flutter/engine#53479) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https:/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes Impeller engine build with
clang-16
and GCC 14 C++Stdlib does not implicitly include<algorithm>
.Fixes issue: #150515
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.