Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API docs footer #150347

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Update API docs footer #150347

merged 1 commit into from
Jun 17, 2024

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Jun 17, 2024

Update API docs footer with a cookie banner (go/cookiebanner) using the glue banner (go/glue-cookiebar)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mit-mit mit-mit requested a review from athomas June 17, 2024 10:49
@mit-mit
Copy link
Member Author

mit-mit commented Jun 17, 2024

Confirmed that ./bots/docs.sh runs with no errors, and deployed the output of that for testing at https://mit-tmp3.web.app

@mit-mit mit-mit merged commit 02356c5 into flutter:master Jun 17, 2024
28 checks passed
@mit-mit mit-mit deleted the fixdocs branch June 17, 2024 17:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 17, 2024
flutter/flutter@5187cab...ccf3abe

2024-06-17 [email protected] Roll Flutter Engine from 2218a4566765 to 5989f0215fed (9 revisions) (flutter/flutter#150373)
2024-06-17 [email protected] Update API docs footer (flutter/flutter#150347)
2024-06-17 [email protected] Update old wiki links (flutter/flutter#149544)
2024-06-17 [email protected] Fix flaky complex_layout_scroll_perf__memory  & flutter_gallery__memory_nav (flutter/flutter#150368)
2024-06-17 [email protected] Roll Packages from dd04ab1 to 711b4ac (3 revisions) (flutter/flutter#150359)
2024-06-17 [email protected] Roll Flutter Engine from 9779c273aac3 to 2218a4566765 (3 revisions) (flutter/flutter#150298)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https:/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants