Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Overflow web view fix #427

Merged
merged 4 commits into from
Feb 12, 2021
Merged

Conversation

gozeloglu
Copy link
Contributor

Hi,

I fixed the problem of overflow on the web view. The related issue is #420 . Can you review my pull request?

@gozeloglu
Copy link
Contributor Author

Hi @rami-a and @guidezpl . I am not able to set you as a reviewer. Can you review my changes?

Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

Can you run flutter pub run grinder update-code-segments?

@gozeloglu
Copy link
Contributor Author

In Turkish error message says that "The system cannot find the file specified."

image

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

Can you run flutter pub run grinder update-code-segments?

@guidezpl
Copy link
Member

Hmm can you try flutter format lib/codeviewer/code_segments.dart and flutter format lib\codeviewer\code_segments.dart on their own? Might be a separator issue

@gozeloglu
Copy link
Contributor Author

Hmm can you try flutter format lib/codeviewer/code_segments.dart and flutter format lib\codeviewer\code_segments.dart on their own? Might be a separator issue

image

I got this.

@guidezpl
Copy link
Member

Can you commit what you have and push?

@gozeloglu
Copy link
Contributor Author

Can you commit what you have and push?

I did

@guidezpl
Copy link
Member

https:/flutter/gallery/blob/03d1151b02e3ddb06ea82b2d4da441d1c09383ca/lib/codeviewer/code_segments.dart looks unformatted, if you can format then commit and push, that should do the trick

@gozeloglu
Copy link
Contributor Author

https:/flutter/gallery/blob/03d1151b02e3ddb06ea82b2d4da441d1c09383ca/lib/codeviewer/code_segments.dart looks unformatted, if you can format then commit and push, that should do the trick

How can I format? Do I need to touch the code and make changes? But, it is a huge file, 2.55 MB :(

@guidezpl
Copy link
Member

Not by hand that's for sure aha. Your first flutter format in #427 (comment) looks like it worked. Just run that without the grinder command

@guidezpl
Copy link
Member

Good to go, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants