Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

[CI] Refactor and improve CI workflows #484

Merged
merged 28 commits into from
Apr 26, 2021
Merged

[CI] Refactor and improve CI workflows #484

merged 28 commits into from
Apr 26, 2021

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Apr 24, 2021 •
edited
Loading

  • Consolidate all test workflows into one
  • Simplify Flutter set up to avoid specifying working directory or modifying PATH
  • Clarify task names
  • Cleanup test locations (test, test_goldens, test_benchmarks, test_driver)
  • Remove the need to specify a specific NDK (has local & CI side effects) by upgrading Gradle version
  • Regenerate some build files

Screenshot 2021-04-24 at 10 39 11

Enables #337, #471

@guidezpl guidezpl changed the title Unify test workflows Refactor and improve CI workflows Apr 24, 2021
rami-a
rami-a approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl merged commit 62fe657 into master Apr 26, 2021
@guidezpl guidezpl deleted the release-refactor branch April 26, 2021 13:17
JoseAlba
JoseAlba reviewed Apr 26, 2021
View reviewed changes
Copy link
Contributor

@JoseAlba JoseAlba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

@guidezpl guidezpl changed the title Refactor and improve CI workflows [CI] Refactor and improve CI workflows Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoseAlba JoseAlba JoseAlba left review comments

@rami-a rami-a rami-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guidezpl @rami-a @JoseAlba