Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Migrate tools to null safety #608

Merged
merged 6 commits into from
Mar 2, 2022
Merged

Conversation

amanv8060
Copy link
Contributor

@amanv8060 amanv8060 commented Feb 20, 2022

Migrates tool/ & gallery options to null safety.

part of #527

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

TextSpan(style: codeStyle.stringStyle, text: '\u0027dart:ui\u0027'),
TextSpan(style: codeStyle.baseStyle, text: ' show '),
TextSpan(style: codeStyle.classStyle, text: 'Vertices'),
TextSpan(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are being generated in a version before this change as well (after updating code-segments) :

    TextSpan(
          style: codeStyle.stringStyle,
          text: '\u0027package:flutter/material.dart\u0027'),
      TextSpan(style: codeStyle.punctuationStyle, text: ';'),
      TextSpan(style: codeStyle.baseStyle, text: '\u000a'),
      TextSpan(style: codeStyle.keywordStyle, text: 'import'),
      TextSpan(style: codeStyle.baseStyle, text: ' '),
      TextSpan(
          style: codeStyle.stringStyle,
          text:
              '\u0027package:flutter_gen/gen_l10n/gallery_localizations.dart\u0027'),
      TextSpan(style: codeStyle.punctuationStyle, text: ';'),
      TextSpan(style: codeStyle.baseStyle, text: '\u000a\u000a'),

which should not be there IMO.

Imports in hosted version :
before

Imports after this change :
after

Copy link
Member

@guidezpl guidezpl Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the issue, but for some unknown reason, the code viewer generates differently on non-Unix platforms. Can you revert the changes to the the updated code? I can add those

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, will revert the code-segments changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guidezpl can you review and add these.

@amanv8060 amanv8060 changed the title [WIP] Migrate tools to null safety Migrate tools to null safety Feb 25, 2022
@amanv8060 amanv8060 requested a review from guidezpl March 1, 2022 18:19
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

@guidezpl guidezpl merged commit 75a2d89 into flutter:master Mar 2, 2022
@amanv8060 amanv8060 deleted the null-safety branch March 2, 2022 19:50
@amanv8060 amanv8060 mentioned this pull request May 16, 2022
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants