This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Added support for enhanced enums in data/demos.dart #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidezpl
suggested changes
May 16, 2022
lib/data/demos.dart
Outdated
| @override | ||
| String toString() { | ||
| return name.toUpperCase(); | ||
| } | ||
| } | ||
|
|
||
| extension GalleryDemoExtension on GalleryDemoCategory { |
There was a problem hiding this comment.
Hi, happy to have you contribute!
Enhanced enums allow us to get rid of this extension, altogether. Can we move displayTitle inside the enum?
There was a problem hiding this comment.
Hey, yes sure i fixed this in the new commit
guidezpl
reviewed
May 16, 2022
pubspec.lock
Outdated
| @@ -49,7 +49,7 @@ packages: | |||
| name: async | |||
| url: "https://pub.dartlang.org" | |||
| source: hosted | |||
| version: "2.9.0" | |||
| version: "2.8.2" | |||
There was a problem hiding this comment.
done, 1 extra commit was created due to me having to pull from master cuz of conflicts
…adabbas02/gallery into enhanced-enums-in-demos.dart Changed the pubspec.lock
guidezpl
approved these changes
May 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request and I'm a new contributor
My pull request should fix issue #680 where I overrode the toString() function and I had to change the minimum SDK in pubspec.yaml to 2.17 to support enhanced enums
Fixes #680