This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
[BottomAppBar Demo] Ensured fab is traversed before bottomAppBar buttons by accessibility… #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidezpl
previously requested changes
Dec 7, 2022
|
LGTM - but can we test this in some way? A verification screencast of the accessibility focus now working as intended would be great. |
esouthren
approved these changes
Dec 13, 2022
harperl-lgtm
dismissed
guidezpl’s stale review
Addressed changes through new commit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR made sure that in BottomAppBar demo the FAB is traversed before BottomAppBar buttons by accessibility focus, which is more intuitive considering that FAB is always above the BottomAppBar buttons.
Issues fixed:
[b/238426806]
BottomAppBar.mp4
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.