This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
dont use TwoPanePageRoute if there is no hinge #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidezpl
reviewed
Mar 6, 2023
lib/routes.dart
Outdated
| @@ -118,7 +118,8 @@ class RouteConfiguration { | |||
| /// route. Set it on the [MaterialApp.onGenerateRoute] or | |||
| /// [WidgetsApp.onGenerateRoute] to make use of the [paths] for route | |||
| /// matching. | |||
| static Route<dynamic>? onGenerateRoute(RouteSettings settings) { | |||
| static Route<dynamic>? onGenerateRoute( | |||
| RouteSettings settings, bool hasHinge) { | |||
guidezpl
approved these changes
Mar 6, 2023
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Apr 20, 2023
Related to flutter/flutter#114402 At least in the flutter gallery test app, with flutter/gallery#909 reverted - this significantly improves the performance in the Xcode frame debugger. If we wanted to do this for more color sources or filter effects, we need to do much more work to track texture opacity, but this seems like a reasonable and low cost first step. ### Before  ### After 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #904
See also: flutter/flutter#120937
The TwoPanePageRoute doesn't use a ModalRoute, leaving the previous route fully active. Additionally, there is no page transition on these route transitions.