Skip to content

Commit

Permalink
[webview_flutter] [webview_flutter_wkwebview]Fix race condition in fl…
Browse files Browse the repository at this point in the history
…aky test (#5068)

Same fix as #5037
  • Loading branch information
Chris Yang authored Oct 3, 2023
1 parent 434b348 commit a66be0e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,9 @@ Future<void> main() async {
'test_header': 'flutter_test_header'
};
await controller.loadUrl(headersUrl, headers: headers);
final String? currentUrl = await controller.currentUrl();
expect(currentUrl, headersUrl);

await pageStarts.stream.firstWhere((String url) => url == currentUrl);
await pageLoads.stream.firstWhere((String url) => url == currentUrl);
await pageStarts.stream.firstWhere((String url) => url == headersUrl);
await pageLoads.stream.firstWhere((String url) => url == headersUrl);

final String content = await controller
.runJavascriptReturningResult('document.documentElement.innerText');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,9 @@ Future<void> main() async {
'test_header': 'flutter_test_header'
};
await controller.loadUrl(headersUrl, headers: headers);
final String? currentUrl = await controller.currentUrl();
expect(currentUrl, headersUrl);

await pageStarts.stream.firstWhere((String url) => url == currentUrl);
await pageLoads.stream.firstWhere((String url) => url == currentUrl);
await pageStarts.stream.firstWhere((String url) => url == headersUrl);
await pageLoads.stream.firstWhere((String url) => url == headersUrl);

final String content = await controller
.runJavascriptReturningResult('document.documentElement.innerText');
Expand Down

0 comments on commit a66be0e

Please sign in to comment.