Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter] Fix XCUITest in Xcode 15 #5071

Merged

Conversation

stuartmorgan
Copy link
Contributor

For some reason tapping the "Done" button in the XCUITest stopped working in Xcode 15, but tapping it via coordinates works, so switch to that as a workaround.

Fixes flutter/flutter#134971

For some reason tapping the "Done" button in the XCUITest stopped
working in Xcode 15, but tapping it via coordinates works, so switch to
that as a workaround.
@stuartmorgan
Copy link
Contributor Author

Normally I would file an issue against Apple and reference it in the comment, but since this is test-only and trivial to work around I don't think it's worth the effort of making a reduced test case.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2023
@auto-submit auto-submit bot merged commit 6714d50 into flutter:main Oct 4, 2023
70 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 5, 2023
flutter/packages@d654f75...6714d50

2023-10-04 [email protected] [webview_flutter] Fix XCUITest in Xcode 15 (flutter/packages#5071)
2023-10-04 [email protected] [path_provider] Fix integration tests (flutter/packages#5075)
2023-10-04 [email protected] [flutter_markdown] Footnote support (flutter/packages#5058)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https:/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
flutter/packages@d654f75...6714d50

2023-10-04 [email protected] [webview_flutter] Fix XCUITest in Xcode 15 (flutter/packages#5071)
2023-10-04 [email protected] [path_provider] Fix integration tests (flutter/packages#5075)
2023-10-04 [email protected] [flutter_markdown] Footnote support (flutter/packages#5058)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https:/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
For some reason tapping the "Done" button in the XCUITest stopped working in Xcode 15, but tapping it via coordinates works, so switch to that as a workaround.

Fixes flutter/flutter#134971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: url_launcher platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XCTests and XCUITests failing on url_launcher package iOS 17 XCode RC1
2 participants