[pigeon] Moves all codec logic to singular custom codec #6600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
force-pushed
the
customcodecs
branch
from
d43b42e
to
a175295
Compare
11 tasks
stuartmorgan
reviewed
May 9, 2024
packages/pigeon/platform_tests/test_plugin/windows/pigeon/core_tests.gen.cpp
Outdated
Show resolved
Hide resolved
stuartmorgan
requested changes
May 23, 2024
| const int64_t enum_arg_value = | ||
| encodable_enum_arg.IsNull() ? 0 : encodable_enum_arg.LongValue(); | ||
| return encodable_enum_arg.IsNull() | ||
| ? CustomEncodableValue(std::nullopt) |
There was a problem hiding this comment.
Shouldn't this just be EncodableValue?
There was a problem hiding this comment.
This was marked as resolved without changes or comment; am I wrong about the type?
There was a problem hiding this comment.
End up with this error when I do EncodableValue https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8746390072007433569/+/u/Run_package_tests/custom_package_tests/stdout?format=raw
There was a problem hiding this comment.
Sorry, I hadn't fully swapped the C++ APIs back in. It should be EncodableValue() for the null case, not EncodableValue(std:nullopt) (which I'm guessing is what gave you that error?). Using EncodableValue() in the null case works for me locally.
...igeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/NullFieldsTest.m
Outdated
Show resolved
Hide resolved
packages/pigeon/platform_tests/alternate_language_test_plugin/ios/Classes/CoreTests.gen.h
Outdated
Show resolved
Hide resolved
...atform_tests/test_plugin/android/src/test/kotlin/com/example/test_plugin/AllDatatypesTest.kt
Show resolved
Hide resolved
vashworth
reviewed
May 23, 2024
stuartmorgan
approved these changes
May 31, 2024
| const int64_t enum_arg_value = | ||
| encodable_enum_arg.IsNull() ? 0 : encodable_enum_arg.LongValue(); | ||
| return encodable_enum_arg.IsNull() | ||
| ? CustomEncodableValue(std::nullopt) |
There was a problem hiding this comment.
This was marked as resolved without changes or comment; am I wrong about the type?
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 7, 2024
flutter/packages@586faa6...8a2c4e4 2024-06-06 [email protected] Revert "Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`." (flutter/packages#6882) 2024-06-06 [email protected] [two_dimensional_scrollables] Adds generics to the callbacks and builders of TreeView (flutter/packages#6864) 2024-06-06 [email protected] Run tests on macOS 13 or 14 (flutter/packages#6877) 2024-06-06 [email protected] Disable sandboxing directly for macOS tests (flutter/packages#6880) 2024-06-06 [email protected] [pigeon] Moves all codec logic to singular custom codec (flutter/packages#6600) 2024-06-06 [email protected] Roll Flutter (stable) from a14f74f to 761747b (6 revisions) (flutter/packages#6878) 2024-06-06 [email protected] Roll Flutter from 27e0656 to 4608a89 (17 revisions) (flutter/packages#6876) 2024-06-06 [email protected] Disable sandboxing for macOS tests in CI (flutter/packages#6866) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https:/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
[pigeon] Moves all codec logic to singular custom codec. Also fixes a few small codec related bugs that have cropped up over time. fixes flutter/flutter#147454 fixes flutter/flutter#147127 fixes flutter/flutter#147587 fixes flutter/flutter#148065
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pigeon] Moves all codec logic to singular custom codec.
Also fixes a few small codec related bugs that have cropped up over time.
fixes flutter/flutter#147454
fixes flutter/flutter#147127
fixes flutter/flutter#147587
fixes flutter/flutter#148065