-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webview_flutter] Skip "Video playback policy" drive tests #6747
Conversation
@@ -302,7 +302,9 @@ Future<void> main() async { | |||
isPaused = | |||
await controller.runJavaScriptReturningResult('isPaused();') as bool; | |||
expect(isPaused, true); | |||
}); | |||
}, | |||
// TODO(bparrishMines): Stop skipping once https:/flutter/flutter/issues/148487 is resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bparrishMines I assigned the TODO to you as code owner since it wouldn't allow me to leave it empty.
Skipping Going to try skipping all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@87a02e3...ae4dd32 2024-05-17 [email protected] Roll Flutter from 0d22d91 to 00425ef (14 revisions) (flutter/packages#6753) 2024-05-16 [email protected] [go_router_builder] Add test for `onExit` (flutter/packages#6614) 2024-05-16 [email protected] [camera_android_camerax] update to latest stable camerax 1.3.3 (flutter/packages#6737) 2024-05-16 [email protected] [camera_avfoundation] Revert camera example PRODUCT_BUNDLE_IDENTIFIER (flutter/packages#6735) 2024-05-16 [email protected] [file_selector_ios, image_picker_ios] Remove Swift Package Support (flutter/packages#6740) 2024-05-16 [email protected] [two_dimensional_scrollables] TreeView (flutter/packages#6592) 2024-05-16 [email protected] Roll Flutter from 39651e8 to 0d22d91 (23 revisions) (flutter/packages#6748) 2024-05-16 [email protected] [pigeon][swift] Removes FlutterError in favor of PigeonError (flutter/packages#6611) 2024-05-16 [email protected] [webview_flutter] Skip "Video playback policy" drive tests (flutter/packages#6747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https:/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Temporary solution for flutter/flutter#148487 to unblock tree.
) Temporary solution for flutter/flutter#148487 to unblock tree.
Temporary solution for flutter/flutter#148487 to unblock tree.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.