Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pointer_interceptor] Add Swift Package Manager support #6790

Merged
merged 2 commits into from
May 24, 2024

Conversation

stuartmorgan
Copy link
Contributor

Adds support for Swift Package Manager on iOS.

Fixes flutter/flutter#146914

Pre-launch Checklist

Adds support for Swift Package Manager on iOS.

Fixes flutter/flutter#146914
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan
Copy link
Contributor Author

test-exempt: configuration change

New SPM support is automatically tested by CI just by adding support for it.

Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2024
@auto-submit auto-submit bot merged commit ce3d2f1 into flutter:main May 24, 2024
74 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 27, 2024
flutter/packages@7b423f5...b7bcb4b

2024-05-26 [email protected] Roll Flutter from cb26a01 to 6564471 (3 revisions) (flutter/packages#6796)
2024-05-26 [email protected] Update Flutter wiki links (flutter/packages#6789)
2024-05-25 [email protected] Roll Flutter from 8dd0831 to cb26a01 (12 revisions) (flutter/packages#6794)
2024-05-24 [email protected] [ci] Switch podspec check over to ARM (flutter/packages#6791)
2024-05-24 [email protected] [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790)
2024-05-24 [email protected] Roll Flutter from 8d955cd to 8dd0831 (22 revisions) (flutter/packages#6788)
2024-05-24 [email protected] [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https:/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
flutter/packages@7b423f5...b7bcb4b

2024-05-26 [email protected] Roll Flutter from cb26a01 to 6564471 (3 revisions) (flutter/packages#6796)
2024-05-26 [email protected] Update Flutter wiki links (flutter/packages#6789)
2024-05-25 [email protected] Roll Flutter from 8dd0831 to cb26a01 (12 revisions) (flutter/packages#6794)
2024-05-24 [email protected] [ci] Switch podspec check over to ARM (flutter/packages#6791)
2024-05-24 [email protected] [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790)
2024-05-24 [email protected] Roll Flutter from 8d955cd to 8dd0831 (22 revisions) (flutter/packages#6788)
2024-05-24 [email protected] [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https:/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: pointer_interceptor platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pointer_interceptor_ios] Add Swift Package Manager compatibility to pointer_interceptor_ios
2 participants