-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pointer_interceptor] Add Swift Package Manager support #6790
[pointer_interceptor] Add Swift Package Manager support #6790
Conversation
Adds support for Swift Package Manager on iOS. Fixes flutter/flutter#146914
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
test-exempt: configuration change New SPM support is automatically tested by CI just by adding support for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@7b423f5...b7bcb4b 2024-05-26 [email protected] Roll Flutter from cb26a01 to 6564471 (3 revisions) (flutter/packages#6796) 2024-05-26 [email protected] Update Flutter wiki links (flutter/packages#6789) 2024-05-25 [email protected] Roll Flutter from 8dd0831 to cb26a01 (12 revisions) (flutter/packages#6794) 2024-05-24 [email protected] [ci] Switch podspec check over to ARM (flutter/packages#6791) 2024-05-24 [email protected] [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790) 2024-05-24 [email protected] Roll Flutter from 8d955cd to 8dd0831 (22 revisions) (flutter/packages#6788) 2024-05-24 [email protected] [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https:/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@7b423f5...b7bcb4b 2024-05-26 [email protected] Roll Flutter from cb26a01 to 6564471 (3 revisions) (flutter/packages#6796) 2024-05-26 [email protected] Update Flutter wiki links (flutter/packages#6789) 2024-05-25 [email protected] Roll Flutter from 8dd0831 to cb26a01 (12 revisions) (flutter/packages#6794) 2024-05-24 [email protected] [ci] Switch podspec check over to ARM (flutter/packages#6791) 2024-05-24 [email protected] [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790) 2024-05-24 [email protected] Roll Flutter from 8d955cd to 8dd0831 (22 revisions) (flutter/packages#6788) 2024-05-24 [email protected] [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https:/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds support for Swift Package Manager on iOS. Fixes flutter/flutter#146914
Adds support for Swift Package Manager on iOS.
Fixes flutter/flutter#146914
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).