Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
Add current non-Java code after merging platform interface PR.
Browse files Browse the repository at this point in the history
  • Loading branch information
KyleFin committed Mar 23, 2022
1 parent 6d7fdee commit 306f679
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion packages/video_player/video_player/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 2.1.15
## 2.3.1

* Adds rotation on Android for videos recorded in landscapeRight Fixes [#60327](https:/flutter/flutter/issues/60327).
* Updates minimum Flutter version to 2.10.

## 2.3.0
Expand Down
3 changes: 2 additions & 1 deletion packages/video_player/video_player/lib/video_player.dart
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class VideoPlayerValue {
/// The [size] of the currently loaded video.
final Size size;

/// Degrees to rotate the video so it is displayed correctly.
/// Degrees to rotate the video (clockwise) so it is displayed correctly.
final int rotationCorrection;

/// Indicates whether or not the video has been loaded and is ready to play.
Expand Down Expand Up @@ -171,6 +171,7 @@ class VideoPlayerValue {
isBuffering: isBuffering ?? this.isBuffering,
volume: volume ?? this.volume,
playbackSpeed: playbackSpeed ?? this.playbackSpeed,
rotationCorrection: rotationCorrection ?? this.rotationCorrection,
errorDescription: errorDescription != _defaultErrorDescription
? errorDescription
: this.errorDescription,
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for displaying inline video with other Flutter
widgets on Android, iOS, and web.
repository: https:/flutter/plugins/tree/main/packages/video_player/video_player
issue_tracker: https:/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.3.0
version: 2.3.1

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ void main() {
VideoPlayerValue(duration: Duration.zero, rotationCorrection: 180));
controller.textureId = 1;
await tester.pumpWidget(VideoPlayer(controller));
Transform actualRotationCorrection =
final Transform actualRotationCorrection =
find.byType(Transform).evaluate().single.widget as Transform;
expect(
actualRotationCorrection.transform, equals(Matrix4.rotationZ(math.pi)));
Expand Down

0 comments on commit 306f679

Please sign in to comment.