Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Platform interface changes to fix Android rotation for videos recorded in landscapeRight #4633

Conversation

KyleFin
Copy link
Contributor

@KyleFin KyleFin commented Dec 21, 2021

Platform interface changes required for #3820 (review)

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#60327

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@KyleFin KyleFin closed this Dec 21, 2021
@KyleFin KyleFin deleted the video_player_android_rotation_plat_interface_changes branch December 21, 2021 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant