Simplify test setup and fix inaccessible Dart/Flutter in container #9416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
requested review from
atsansone,
sfshaza2 and
khanhnwin
as code owners
|
Visit the preview URL for this PR (updated for commit 0f605ad): https://flutter-docs-prod--pr9416-fix-expose-cloned-fl-fnqqorlv.web.app (expires Tue, 26 Sep 2023 15:39:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
parlough
changed the title
AlexV525
reviewed
Sep 19, 2023
3 tasks
atsansone
approved these changes
Sep 19, 2023
atsansone
pushed a commit
that referenced
this pull request
Sep 21, 2023
…9416) #9307 caused `dart` and `flutter` to not be accessible when running inside the container. This PR attaches the cloned Flutter repository as a volume to allow it to persist and be accessible. To be compatible with these changes, also modifies the `test.sh` script to be simpler, not allowing switching branches separately from the container. When it's ran from GitHub actions, a new container is created anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9307 caused
dartandflutterto not be accessible when running inside the container. This PR attaches the cloned Flutter repository as a volume to allow it to persist and be accessible.To be compatible with these changes, also modifies the
test.shscript to be simpler, not allowing switching branches separately from the container. When it's ran from GitHub actions, a new container is created anyway.