Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): set title for chooser #3306

Closed

Conversation

holzgeist
Copy link

Description

This PR sets the EXTRA_TITLE data on Android Intents if a subject was given. This is used as the title for the chooser dialog as per documentation. It's also what Chromium uses for its Share API, see here

Re: Contributing.md:
On iOS, the Chooser already shows the given subject as title. Just as additional input for contribution type 🟡 (Changing a platform implementation)

Related Issues

Did not find nor file an issue for this yet

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing. (at least local ones, let's see about workflow runs)
  • The analyzer (flutter analyze) does not report any problems on my PR. (no new ones at least, it reports the same issues as on main)

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member

Thanks @holzgeist

There is another open PR discussing a similar solution: #3270

I'd prefer to discuss this before in a feature request ticket, as passing both extra_subject and extra_title with the same value can have unintended side effects on existing apps.

I will close this and the other PR and please request you to create a request ticket instead.

@holzgeist
Copy link
Author

@miquelbeltran thanks for the quick response. I see the issue with "Did not find nor file an issue for this yet" now :D

@miquelbeltran
Copy link
Member

I created a ticket for it: #3307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants