-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align to Kubernetes structured logging #3051
Labels
umbrella-issue
Umbrella issue for tracking progress of a larger effort
Comments
stefanprodan
added
the
umbrella-issue
Umbrella issue for tracking progress of a larger effort
label
Aug 30, 2022
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've been delaying the upgrade to controller-runtime v0.12 due to the changes to structured logging. I think it's time to align the Flux controllers logs with Kubernetes, even if the new logging format is more verbose.
Current format (flux2 v0.33.0):
New format:
Breaking changes
These fields have been renamed:
logger
->controller
reconciler group
->controllerGroup
reconciler kind
->controllerKind
🗒️ Projects
Prerequisites
fluxcd/pkg
: update all packages to controller-runtime v0.12fluxcd/pkg/runtime
: release new Flux runtime package based on controller-runtime v0.12Controllers
Update
fluxcd/pkg/runtime
and remove our customreconcileID
in favour of the upstream one.fluxcd/notification-controller
(depends on prerequisites)fluxcd/image-reflector-controller
(depends on prerequisites)fluxcd/source-controller
(depends on prerequisites)fluxcd/kustomize-controller
(depends onfluxcd/source-controller
)fluxcd/helm-controller
(depends onfluxcd/source-controller
)fluxcd/image-automation-controller
(depends onfluxcd/source-controller
andfluxcd/image-reflector-controller
)CLI
fluxcd/flux2
: adaptflux logs
to the new format in a backwards compatible manner ( support bothreconciler kind
andcontrollerKind
)The text was updated successfully, but these errors were encountered: