Add sourcesecret and kustomization manifestgen
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
manifestgen-deploysecret-kustomization
branch
2 times, most recently
from
054d1d0
to
c49ee87
Compare
|
I find the |
hiddeco
changed the title
deploysecret and kustomization manifestgengitsecret and kustomization manifestgen
hiddeco
force-pushed
the
manifestgen-deploysecret-kustomization
branch
8 times, most recently
from
e239978
to
183aaf8
Compare
hiddeco
changed the title
gitsecret and kustomization manifestgensourcesecret and kustomization manifestgen
hiddeco
force-pushed
the
manifestgen-deploysecret-kustomization
branch
5 times, most recently
from
7700aa2
to
c78a0be
Compare
This includes a change to the `sync` generator to make the deploy secret name configurable. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
manifestgen-deploysecret-kustomization
branch
from
c78a0be
to
8a5bba8
Compare
hiddeco
added
area/bootstrap
stefanprodan
approved these changes
Feb 26, 2021
hiddeco
added a commit
that referenced
this pull request
Mar 16, 2021
Regression bug introduced in #1001. Signed-off-by: Hidde Beydals <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a change to the
syncgenerator to make the deploysecret name configurable for future implementation by deploy refactor in #968.