-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a preview note for all non-bootstrap commands #3754
add a preview note for all non-bootstrap commands #3754
Conversation
@aryan9600 please rebase with the release-v2.0.0-rc.1 |
8da47ec
to
b96277a
Compare
@aryan9600 the warning must be displayed only on commands that don't deal with v1 APIs. As listed here: #3274 |
b96277a
to
03aeec8
Compare
03aeec8
to
c26633f
Compare
381b1c7
to
c8db969
Compare
@@ -42,7 +42,7 @@ var createKsCmd = &cobra.Command{ | |||
Use: "kustomization [name]", | |||
Aliases: []string{"ks"}, | |||
Short: "Create or update a Kustomization resource", | |||
Long: "The create command generates a Kustomization resource for a given source.", | |||
Long: `The create command generates a Kustomization resource for a given source.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe undo such changes to keep the diff focused on non-GA commands only?
Or convert all the long message of every command to use the same syntax.
Just wanted to see how others feel about the idea I've been thinking about while going though the changes. |
Yes, I agree. Seeing the warning on |
Yes +1 |
Signed-off-by: Sanskar Jaiswal <[email protected]>
c8db969
to
8d09c66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
add the following note to all non-GA commands as described in #3274:
fixes #3739