-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pkg/runtime helpers #322
Labels
enhancement
New feature or request
Milestone
Comments
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of the refactor work to set out some standards for the controllers that are part of the Flux family, the
pkg/runtime
helpers and interfaces should be implemented to work with the conditions, metrics and events recorded for HelmRelease resources.In short, (at least) the following should be implemented:
HelmRelease
should implement the interfaces fromconditions
, and use this package to work with conditions.HelmReleaseReconciler
should implement the helpers fromcontroller
, and use these to record Events and Metrics.HelmReleaseReconciler
should exit early without recording any status when.spec.suspend
is defined.patch
package should be implemented to (safely) patch resources without running into conflicts.kstatus
Reconciling
andStalled
conditions should be properly implemented to provide better signals.More examples can be found at:
HelmRepositoryReconciler
to new standards source-controller#413The text was updated successfully, but these errors were encountered: