Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent code-style raised at security audit #386

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Fix inconsistent code-style raised at security audit #386

merged 2 commits into from
Dec 22, 2021

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Dec 21, 2021

Changes summary:

  • Add check for nil to fix inconsistent code-style raised at the security audit.
  • Short-circuit function when ExternalEventRecorder is nil.

Relates to fluxcd/pkg#173

Paulo Gomes added 2 commits December 21, 2021 14:03
Check EventRecorder is not nil
c9b1a4f 
Signed-off-by: Paulo Gomes <[email protected]>
Short-circuit event handling
0837f6f 
When ExternalEventRecorder is nil, the helm release reference is not used
therefore the function can safely return early.

Signed-off-by: Paulo Gomes <[email protected]>
stefanprodan
stefanprodan approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

@stefanprodan stefanprodan merged commit e2b988a into fluxcd:main Dec 22, 2021
@pjbgf pjbgf deleted the audit-followup branch December 22, 2021 08:50
@pjbgf pjbgf mentioned this pull request Feb 16, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjbgf @stefanprodan