Update pkg/runtime and apis/meta
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
runtime-meta-rc
branch
from
b36c816
to
0f96971
Compare
There was a problem hiding this comment.
You have to deploy SC v1beta2 for e2e testing, here is an example from KC https:/fluxcd/kustomize-controller/blob/3117a4e8d20b80039e34ad55f0241cc2f866e060/config/default/kustomization.yaml
darkowlzz
force-pushed
the
runtime-meta-rc
branch
3 times, most recently
from
a87f9dd
to
7f92d98
Compare
darkowlzz
force-pushed
the
runtime-meta-rc
branch
2 times, most recently
from
cd9d5c5
to
df62e6b
Compare
hiddeco
approved these changes
Mar 18, 2022
This includes an update of the source-controller to v0.22.0, to pull in the v1beta2 API which makes use of the same packages. Signed-off-by: Sunny <[email protected]>
hiddeco
force-pushed
the
runtime-meta-rc
branch
from
df62e6b
to
6bd29a7
Compare
hiddeco
added a commit
that referenced
this pull request
Mar 22, 2022
Follow up on #421 to fully implement new tooling requirements. By implementing the interfaces, the `conditions` package can now be used. Signed-off-by: Hidde Beydals <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an update of the source-controller to v0.22.0, to pull in
the v1beta2 API which makes use of the same packages.