Add PersistentClient flag to allow control over Kubernetes client behavior
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
enhancement
hiddeco
force-pushed
the
flag-persistent-client
branch
2 times, most recently
from
0fc0844
to
71bc8af
Compare
15 tasks
This adds a `PersistentClient` flag which should be consumed by the controller while initializing the Kubernetes client used by Helm actions. This to allow the controller to work with certain charts which do require a client which does not persist, as they create Custom Resource Definitions on demand during e.g. install, which then later aren't observed by Helm as it does not reset the REST mapper between successive action steps. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
flag-persistent-client
branch
from
71bc8af
to
c93b3af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
PersistentClientflag to theHelmReleaseto allow control over the behavior of the Kubernetes client used by Helm actions.When enabled, the client will be reused for the duration of the reconciliation, instead of being created and destroyed for each (step of a) Helm action. This can improve performance (see #630), but may cause issues with some Helm charts (as reported in #655) that for example do create Custom Resource Definitions during installation outside Helm's CRD lifecycle hooks, which are then not observed to be available by e.g. post-install hooks.
If not set, it defaults to
true. Making this effectively an opt-out.Addresses option two from #655 (comment)