Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runner: address regression in captured Helm logs #767

Merged
merged 2 commits into from
Sep 11, 2023
Merged

runner: address regression in captured Helm logs #767

merged 2 commits into from
Sep 11, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Sep 11, 2023

Fixes #765

@hiddeco hiddeco added the bug Something isn't working label Sep 11, 2023
@hiddeco
Copy link
Member Author

hiddeco commented Sep 11, 2023

With this patch, emitted event looks as follows:

Warning  error   14m   helm-controller  Helm upgrade failed: context deadline exceeded

Last Helm logs:

Patch Deployment "podinfo-helmrepository" in namespace default
waiting for release podinfo-helmrepository resources (created: 0 updated: 2  deleted: 0)
beginning wait for 2 resources with timeout of 5m0s
Deployment is not ready: default/podinfo-helmrepository. 0 out of 1 expected pods are ready
warning: Upgrade "podinfo-helmrepository" failed: context deadline exceeded

@hiddeco
runner: address regression in captured Helm logs
eb3a4b8 
This addresses a regression in the Helm log capturing introduced in
3b25041, which prevented valuable
information from the Kube client logs (e.g. the specific reason for a
timeout) to be added to the event emitted in case of a failure.

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
controller: strip newlines from Helm error message
1aa7390 
To prevent spurious newlines between the error message and the captured
logs, as at times Helm ends error with one or multiple newlines.

Signed-off-by: Hidde Beydals <[email protected]>
stefanprodan
stefanprodan approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit c94ee3b into main Sep 11, 2023
6 checks passed
@hiddeco hiddeco deleted the fix-captured-logs-regression branch September 11, 2023 15:13
@stefanprodan stefanprodan mentioned this pull request Sep 18, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm-controller: logs from Helm actions no longer seem to be captured
2 participants
@hiddeco @stefanprodan