-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/spec: document v2beta2
API
#828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
document-v2beta2
branch
3 times, most recently
from
December 6, 2023 11:19
6d9673c
to
ce9ab63
Compare
stefanprodan
reviewed
Dec 6, 2023
hiddeco
force-pushed
the
document-v2beta2
branch
11 times, most recently
from
December 7, 2023 09:48
482f026
to
5942f39
Compare
hiddeco
force-pushed
the
document-v2beta2
branch
3 times, most recently
from
December 8, 2023 16:21
cfa1f70
to
8230c00
Compare
aryan9600
reviewed
Dec 8, 2023
hiddeco
force-pushed
the
document-v2beta2
branch
2 times, most recently
from
December 11, 2023 14:43
26d4145
to
5b4ebf2
Compare
darkowlzz
reviewed
Dec 11, 2023
hiddeco
force-pushed
the
document-v2beta2
branch
2 times, most recently
from
December 11, 2023 15:43
e6890e5
to
a0af3d6
Compare
darkowlzz
reviewed
Dec 11, 2023
darkowlzz
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
darkowlzz
reviewed
Dec 11, 2023
darkowlzz
reviewed
Dec 11, 2023
aryan9600
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! amazing job 🙇
makkes
reviewed
Dec 11, 2023
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
document-v2beta2
branch
from
December 11, 2023 17:29
6cced7d
to
9afd20c
Compare
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
document-v2beta2
branch
from
December 11, 2023 17:52
9afd20c
to
bb5a03b
Compare
makkes
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement over the current docs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be nice to add (but could be added later):