Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/spec: document v2beta2 API #828

Merged
merged 19 commits into from
Dec 11, 2023
Merged

docs/spec: document v2beta2 API #828

merged 19 commits into from
Dec 11, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Dec 6, 2023

Would be nice to add (but could be added later):

  • More advanced examples on some subjects.

@hiddeco hiddeco added the area/docs Documentation related issues and pull requests label Dec 6, 2023
@hiddeco hiddeco force-pushed the document-v2beta2 branch 3 times, most recently from 6d9673c to ce9ab63 Compare December 6, 2023 11:19
@hiddeco hiddeco force-pushed the document-v2beta2 branch 11 times, most recently from 482f026 to 5942f39 Compare December 7, 2023 09:48
@hiddeco hiddeco marked this pull request as ready for review December 7, 2023 09:48
@hiddeco hiddeco force-pushed the document-v2beta2 branch 3 times, most recently from cfa1f70 to 8230c00 Compare December 8, 2023 16:21
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Show resolved Hide resolved
@hiddeco hiddeco force-pushed the document-v2beta2 branch 2 times, most recently from 26d4145 to 5b4ebf2 Compare December 11, 2023 14:43
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
@hiddeco hiddeco force-pushed the document-v2beta2 branch 2 times, most recently from e6890e5 to a0af3d6 Compare December 11, 2023 15:43
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Show resolved Hide resolved
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! amazing job 🙇

docs/spec/v2beta2/helmreleases.md Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Outdated Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Show resolved Hide resolved
docs/spec/v2beta2/helmreleases.md Show resolved Hide resolved
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement over the current docs!

@hiddeco hiddeco merged commit 14a333d into main Dec 11, 2023
6 checks passed
@hiddeco hiddeco deleted the document-v2beta2 branch December 11, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants