Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch ambiguously defined for ImageUpdateAutomation as well as for git repo #113

Closed
davidkarlsen opened this issue Feb 23, 2021 · 2 comments

Comments

@davidkarlsen
Copy link

https://toolkit.fluxcd.io/guides/image-update/:
ImageUpdateAutomation takes a branch parameter, but so does the git-repo it refers, this seems ambiguous to me, you want to refer the git repo it was defined in, and that's already defined in the GitRepository - hence it should be sufficient with the gitRepositoryRef.

spec:
checkout:
branch: main <--
gitRepositoryRef:
name: flux-system <-- this repo already has a branch defined

Maybe a bit related to #85

@squaremo
Copy link
Member

Also pertinent: the discussion in fluxcd/flux2#665

@pjbgf
Copy link
Member

pjbgf commented Mar 22, 2022

@davidkarlsen thank you for reporting this. This has been fixed in version v0.9.0 with the introduction of API version v1alpha2.

The change allows for ImageUpdateAutomation to optionally set checkout references in the same way as in the GitRepository objects and when not set it defaults to the value set in the GitRepository references to by the sourceRef field.

For more information, including the migration path, please check the documentation.

I will be closing this issue now, but feel free add a comment here in case you want this reopened.

@pjbgf pjbgf closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants