Commits on Jul 13, 2021

1. Fail push if a ref update is rejected …

   libgit2's Push method will succeed even when ref updates are rejected,
   meaning it can silently fail if you e.g., use branch protection in
   GitHub.
   
   To make these errors visible, a callback is supplied to Push, which
   checks for a non-empty status (on the advice of
   https://libgit2.org/libgit2/#HEAD/group/callback/git_push_update_reference_cb).
   
   For whatever reason, gogit seems overly sensitive to hook errors (in a
   way that `git` and libgit2 aren't), and reports "invalid pkg-len
   found" when it sees a rejected ref message. This doesn't affect the
   runtime code, since that uses libgit2 -- but it does affect the test
   code, which initialises the git repo used in many tests, so more care
   is needed to push only the main branch, so as not to trigger a
   rejection.
   
   Signed-off-by: Michael Bridgen <[email protected]>

   

   squaremo committed Jul 13, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 3476ecb
   • Browse repository at this point

   Copy the full SHA

   3476ecb View commit details

   Browse the repository at this point in the history