Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context to libgit2.RemoteCallbacks #252

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Pass context to libgit2.RemoteCallbacks #252

merged 1 commit into from
Nov 4, 2021

Conversation

darkowlzz
Copy link
Contributor

@darkowlzz darkowlzz commented Nov 1, 2021

Pass cancellable context to libgit2.RemoteCallbacks to be able to cancel
the remote operations when the context is cancelled.
For git clone, the context is created with the timeout specified in the target
GitRepository.

Based on the source-controller changes in fluxcd/source-controller#477.

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @darkowlzz 🙇

Pass cancellable context to libgit2.RemoteCallbacks to be able to cancel
the remote operations when the context is cancelled.
For git clone, fetch and push, a context is created with the timeout of
the target GitRepository.

Signed-off-by: Sunny <[email protected]>
@darkowlzz darkowlzz merged commit 041018f into main Nov 4, 2021
@darkowlzz darkowlzz deleted the libgit2-timeout branch November 4, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants