Configure libgit2 fetch and push ProxyOptions #285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to fluxcd/source-controller#524, this PR allows to specify an HTTP(S) proxy for Git operations through environment variables.
Fixes #279.
This is a draft for now because the current version of git2go's bindings do not allow to specify ProxyOptions for push operations, only for clone and fetch.
It first requires libgit2/git2go#872 to be merged and backported to release-1.1 (v31), which is the version of libgit2 used by image-automation-controller (and source-controller).