Add support for cross-namespace sourceRef in ImageUpdateAutomation #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
requested changes
Jan 21, 2022
aryan9600
force-pushed
the
aryan9600/ref-gitrepo-cross-ns
branch
from
e51acbe
to
a7d4c60
Compare
stefanprodan
requested changes
Jan 21, 2022
aryan9600
force-pushed
the
aryan9600/ref-gitrepo-cross-ns
branch
from
1410e16
to
c5e1415
Compare
aryan9600
force-pushed
the
aryan9600/ref-gitrepo-cross-ns
branch
from
a45b58e
to
8bf5e1e
Compare
ImageUpdateAutomation objects can now refer to GitRepository objects in other namespaces. Implemented by switching sourceRef from a SourceReference to a dependency.CrossNamespaceDependencyReference. Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
aryan9600/ref-gitrepo-cross-ns
branch
from
8bf5e1e
to
3de51e7
Compare
24 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageUpdateAutomation objects can now refer to GitRepository objects in other
namespaces. Implemented by switching sourceRef from a SourceReference to a
dependency.CrossNamespaceDependencyReference.
Fix: #294
Fix: #201
Fix: #180
Signed-off-by: Sanskar Jaiswal [email protected]