Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fuzzing tests using oss-fuzz-build. #314

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

aryan9600
Copy link
Member

  • Structure the fuzz implementation to be closer to what fuzz testing might look like once leveraging the golang 1.18 built-in fuzz feature.
  • Add Makefile target to enable smoke testing fuzzers locally.
  • Add github workflow to smoke test fuzzers.

Supersedes #229

Co-authored-by: Paulo Gomes [email protected]
Co-authored-by: AdamKorcz [email protected]
Signed-off-by: Sanskar Jaiswal [email protected]

@aryan9600 aryan9600 force-pushed the aryan9600/fuzz-tests branch 3 times, most recently from b719b8b to e024c9b Compare February 10, 2022 13:37
@hiddeco hiddeco added the area/ci CI related issues and pull requests label Feb 10, 2022
Comment on lines 23 to 24
- name: Fetch CRDs
run: make test_deps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must happen within the build.sh script. To support the oss-fuzz integration that script must be self sufficient to setup all dependencies required to build the application.

@aryan9600 aryan9600 force-pushed the aryan9600/fuzz-tests branch 6 times, most recently from 14da24c to 1b3e04d Compare February 11, 2022 14:27
Co-authored-by: Paulo Gomes <[email protected]>
Co-authored-by: AdamKorcz <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @aryan9600! LGTM

@pjbgf
Copy link
Member

pjbgf commented Feb 11, 2022

I tested this with the oss-fuzz integration, and I can confirm it is working as expected.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 and @pjbgf

@stefanprodan stefanprodan merged commit 09a0191 into fluxcd:main Feb 12, 2022
@pjbgf pjbgf mentioned this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants