Update libgit2 to 1.3.0 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
force-pushed
the
libgit2-130
branch
4 times, most recently
from
d811077
to
f618292
Compare
| @@ -1413,3 +1435,77 @@ func mergeBranchIntoHead(repo *git.Repository, pushBranch string) { | |||
| }) | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| } | |||
|
|
|||
| // copied from source-controller/pkg/git/libgit2/checkout.go | |||
| func commitFile(repo *git2go.Repository, path, content string, time time.Time) (*git2go.Oid, error) { | |||
There was a problem hiding this comment.
I think we should rewrite the commit logic using libgit2
There was a problem hiding this comment.
I rewrote the gitInitRepo with libgit2, which was enough to remove the need for the adhoc fix.
Can we go ahead with the libgit2 to 1.3.0 on this PR and then any further rewrite/replacement of go-git we can deal on a separate PR.
pjbgf
force-pushed
the
libgit2-130
branch
2 times, most recently
from
9d0de93
to
bc4a4e0
Compare
added 5 commits
March 1, 2022 14:48
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update source controller to
v0.21.3(fluxcd/source-controller#589) and update libgit2 tov1.3.0.Fixes #320